Change in libosmocore[master]: gsm: Fix compilation error under some compilers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 4 10:11:32 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15954 )

Change subject: gsm: Fix compilation error under some compilers
......................................................................

gsm: Fix compilation error under some compilers

Some compilers don't like declaration of enums in header files like we
do sometimes for structs:
enum gsm_band;
void foobar(enum gsm_band band);

triggers:
error: use of enum 'gsm_band' without previous declaration

Fixes: b99f4ca2d8517d99cdf8aa183dbfda7b233bb781
Related: OS#4244
Change-Id: I6c2102c763f565bbe3c8dd7e5b4e04c4a45fff67
---
M include/osmocom/gsm/gsm_utils.h
M include/osmocom/gsm/protocol/gsm_04_08.h
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  osmith: Looks good to me, approved
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h
index 7a5da9a..38a3f6e 100644
--- a/include/osmocom/gsm/gsm_utils.h
+++ b/include/osmocom/gsm/gsm_utils.h
@@ -30,7 +30,6 @@
 
 #include <osmocom/core/defs.h>
 #include <osmocom/core/utils.h>
-#include <osmocom/gsm/protocol/gsm_04_08.h>
 
 #define ADD_MODULO(sum, delta, modulo) do {	\
 	if ((sum += delta) >= modulo)		\
diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h
index b5317d5..68ec4e3 100644
--- a/include/osmocom/gsm/protocol/gsm_04_08.h
+++ b/include/osmocom/gsm/protocol/gsm_04_08.h
@@ -9,8 +9,9 @@
 #include <osmocom/core/utils.h>
 #include <osmocom/core/endian.h>
 
+#include <osmocom/gsm/gsm_utils.h>
+
 struct gsm_lchan;
-enum gsm_band;
 
 /* Chapter 10.5.1.5 */
 struct gsm48_classmark1 {

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c2102c763f565bbe3c8dd7e5b4e04c4a45fff67
Gerrit-Change-Number: 15954
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191104/a6b6e719/attachment.htm>


More information about the gerrit-log mailing list