Change in osmo-msc[master]: validate dtap err logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Sun Nov 3 23:21:20 UTC 2019


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/15949 )


Change subject: validate dtap err logging
......................................................................

validate dtap err logging

Change-Id: I3edd90be40555dd648e9f16db5b6040665a19a95
---
M tests/msc_vlr/msc_vlr_tests.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/49/15949/1

diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c
index de4913a..e00c337 100644
--- a/tests/msc_vlr/msc_vlr_tests.c
+++ b/tests/msc_vlr/msc_vlr_tests.c
@@ -254,8 +254,10 @@
 
 	/* Mask the sequence number out before comparing */
 	msg->data[1] &= 0x3f;
-	if (!msgb_eq_data_print(msg, dtap_tx_expected->data, dtap_tx_expected->len))
+	if (!msgb_eq_data_print(msg, dtap_tx_expected->data, dtap_tx_expected->len)) {
+		btw("Expected %s", osmo_hexdump(dtap_tx_expected->data, dtap_tx_expected->len));
 		abort();
+	}
 
 	btw("DTAP matches expected message");
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3edd90be40555dd648e9f16db5b6040665a19a95
Gerrit-Change-Number: 15949
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191103/4716ec9e/attachment.htm>


More information about the gerrit-log mailing list