Change in osmo-hlr[master]: fix upgrade to version 2: imei column default value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Fri Nov 1 16:50:46 UTC 2019


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/15911 )

Change subject: fix upgrade to version 2: imei column default value
......................................................................


Patch Set 1:

(1 comment)

> Adding Oliver, as he is the author of the related code (to my best knowledge).

I'm pretty sure it was stsp

https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c 
File src/db.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/15911/1/src/db.c@a302 
PS1, Line 302: default NULL
> Shouldn't IMEI actually be NULL by default? AFAIK, storing IMEI(SV) is an optional feature, so what  […]
In this patch I want to achieve that an upgraded DB yields exactly the same schema as a newly created db.

(If we want to change the 'default's, we need to create a new db schema version to change that.
The default is empty, and I guess 'default NULL' could even be equivalent to leaving it empty.
So I guess we don't need to change the 'default's.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/15911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I68a00014a3d603fcba8781470bc5285f78b538d0
Gerrit-Change-Number: 15911
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 16:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191101/e773d026/attachment.htm>


More information about the gerrit-log mailing list