Change in libosmocore[master]: vty_transcript_test.vty: add choice auto-complete tests

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 31 19:52:08 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14307 )

Change subject: vty_transcript_test.vty: add choice auto-complete tests
......................................................................


Patch Set 1:

The problem is somewhere in cmd_execute_command_real(). Instead of composing 'argv' from 'vline', we need to use 'matched_element'.

Some info from gdb:

  $ gdb -q ./vty_transcript_test
  (gdb)$ b command.c:2322

  $ telnet localhost 42042
  $ vty_transcript_test> th

  (gdb)$ bt
    #0  cmd_execute_command_real (vline=0x62ac30, vty=0x6295e0, cmd=0x0) at command.c:2321
    #1  0x00007ffff7767575 in cmd_execute_command (vline=0x62ac30, vty=0x6295e0, cmd=0x0, vtysh=0x0) at command.c:2354
    #2  0x00007ffff776ab79 in vty_command (vty=0x6295e0, buf=0x629790 "multi0 th") at vty.c:431
    #3  0x00007ffff776b3a0 in vty_execute (vty=0x6295e0) at vty.c:695
    #4  0x00007ffff776cf8c in vty_read (vty=0x6295e0) at vty.c:1419
    #5  0x00007ffff776f5f1 in client_data (fd=0x629538, what=0x1) at telnet_interface.c:147
    #6  0x00007ffff7ba01c4 in osmo_fd_disp_fds (_rset=0x7fffffffda20, _wset=0x7fffffffdaa0, _eset=0x7fffffffdb20) at select.c:223
    #7  0x00007ffff7ba0349 in osmo_select_main (polling=0x0) at select.c:263
    #8  0x00000000004016d2 in main (argc=0x1, argv=0x7fffffffdcb8) at vty/vty_transcript_test.c:232
    #9  0x00007ffff73b3f45 in __libc_start_main (main=0x40154b <main>, argc=0x1, argv=0x7fffffffdcb8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdca8) at libc-start.c:287
#10 0x00000000004010f9 in _start ()

  (gdb)$ p (char *) (vline->index[0])
    $131 = 0x62ad20 "multi0"
  (gdb)$ p (char *) (vline->index[1])
    $132 = 0x62ad90 "th"

  (gdb)$ p (char *) *((struct _vector *)((struct _vector *)((struct _vector *)(matched_element->strvec->index[0])))->index[0])
    $133 = 0x626400 "multi0"
  (gdb)$ p (char *) *((struct _vector *)((struct _vector *)((struct _vector *)(matched_element->strvec->index[1])))->index[0])
    $134 = 0x626660 "one"
  (gdb)$ p (char *) *((struct _vector *)((struct _vector *)((struct _vector *)(matched_element->strvec->index[1])))->index[1])
    $135 = 0x626390 "two"
  (gdb)$ p (char *) *((struct _vector *)((struct _vector *)((struct _vector *)(matched_element->strvec->index[1])))->index[2])
    $136 = 0x626840 "three"


-- 
To view, visit https://gerrit.osmocom.org/14307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83c3aef813173952641035862c534ef16384780e
Gerrit-Change-Number: 14307
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 31 May 2019 19:52:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/11e5052b/attachment.html>


More information about the gerrit-log mailing list