Change in osmocom-bb[master]: trxcon/sched_mframe.c: mark all stolen CBCH UL slots as TRXC_IDLE

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 31 16:51:44 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/14281 )

Change subject: trxcon/sched_mframe.c: mark all stolen CBCH UL slots as TRXC_IDLE
......................................................................

trxcon/sched_mframe.c: mark all stolen CBCH UL slots as TRXC_IDLE

According to 3GPP TS 05.02, section 6.4.1, CBCH replaces
SDCCH number 2 in both V (BCCH+CCCH+SDCCH/4+SACCH/4) and
VII (SDCCH/8+SACCH/8) logical channel combinations.

Unfortunately it is not clear whether we can use stolen UL slots
for RACH or not. For now, we should mark all of them as IDLE.

Somehow TRXC_SDCCH4_2 slots were left in the definition of
combination V (combined CCCH+BCCH). This is not critical,
but may be looking confusing. Let's fix this.

Change-Id: Id30f2fac3274de3edff4ae59f77d9c9cf8059155
---
M src/host/trxcon/sched_mframe.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/sched_mframe.c b/src/host/trxcon/sched_mframe.c
index d427993..9b759af 100644
--- a/src/host/trxcon/sched_mframe.c
+++ b/src/host/trxcon/sched_mframe.c
@@ -292,10 +292,10 @@
 	{ TRXC_IDLE,		2,	TRXC_SDCCH4_1,	3 },
 	{ TRXC_IDLE,		3,	TRXC_RACH,	0 },
 	{ TRXC_SACCH4_3,	0,	TRXC_RACH,	0 },
-	{ TRXC_SACCH4_3,	1,	TRXC_SDCCH4_2,	0 },
-	{ TRXC_SACCH4_3,	2,	TRXC_SDCCH4_2,	1 },
-	{ TRXC_SACCH4_3,	3,	TRXC_SDCCH4_2,	2 },
-	{ TRXC_IDLE,		0,	TRXC_SDCCH4_2,	3 },
+	{ TRXC_SACCH4_3,	1,	TRXC_IDLE,	0 },
+	{ TRXC_SACCH4_3,	2,	TRXC_IDLE,	1 },
+	{ TRXC_SACCH4_3,	3,	TRXC_IDLE,	2 },
+	{ TRXC_IDLE,		0,	TRXC_IDLE,	3 },
 };
 
 static const struct trx_frame frame_sdcch8[102] = {

-- 
To view, visit https://gerrit.osmocom.org/14281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id30f2fac3274de3edff4ae59f77d9c9cf8059155
Gerrit-Change-Number: 14281
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/77e69d65/attachment.html>


More information about the gerrit-log mailing list