Change in osmo-pcu[master]: encoding: correct encoding of CRBB in ACK/NACK when not byte aligned

lynxis lazus gerrit-no-reply at lists.osmocom.org
Fri May 31 15:59:21 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/14302


Change subject: encoding: correct encoding of CRBB in ACK/NACK when not byte aligned
......................................................................

encoding: correct encoding of CRBB in ACK/NACK when not byte aligned

The last bits of the CRBB (compressed receive block bitmap) was incorrect
encoded when the CRBB is not byte aligned.

Related: OS#3728
Change-Id: I7261aa71b37d7ead52992f8db462f72a3804988e
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/02/14302/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index 1b325b4..b6879cc 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -965,7 +965,7 @@
 				crbb_len = crbb_len - 8;
 				iter++;
 			} else {
-				bitvec_write_field(dest, &wp, crbb_bitmap[iter], crbb_len);
+				bitvec_write_field(dest, &wp, crbb_bitmap[iter] >> (8 - crbb_len), crbb_len);
 				crbb_len = 0;
 			}
 		}

-- 
To view, visit https://gerrit.osmocom.org/14302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7261aa71b37d7ead52992f8db462f72a3804988e
Gerrit-Change-Number: 14302
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/62273399/attachment-0001.html>


More information about the gerrit-log mailing list