Change in osmo-ggsn[master]: gtp: Introduce new pdp APIs (and deprecate old ones) to support multi...

Pau Espin Pedrol gerrit-no-reply at
Fri May 31 15:16:01 UTC 2019

Pau Espin Pedrol has uploaded a new patch set (#2). ( )

Change subject: gtp: Introduce new pdp APIs (and deprecate old ones) to support multiple GSN

gtp: Introduce new pdp APIs (and deprecate old ones) to support multiple GSN

Move static global pdp storage arrays to be per GSN. This way now
several GSN per process are supported without collisions.

* pdp_init() is defined in public API but it's actually only intended
for use (and currently only used) internally in gtp_new(). So let's
document that and re-use it for backward compatibility with now
deprecated API, where only one GSN per process is supported.

* Back pointer to gsn_t (pdp->gsn) moved from gtp.c:gtp_new() to
gtp_pdp_newpdp(), since it makes more sense to have it there. This way
backpointer is always set, even in case were app calls pdp_newpdp() API
directly instead of creating them through gtp.c, like osmo-sgsn does.

* Create new versions of required APIs with a pointer to gsn_t where the
pdp ctx is to be created/found. Some APIs receiving a pointer to a pdp
ctx can be left intact because we have a backpointer to its gsn_t.

* pdp_getpdp() is nowhere used, and makes little sense now that we have
pdpa reachable in gsn->pdpa, so let's deprecate it without adding a

* Deprecate gtp.h gtp_newpdp(), since it's nowhere used and useless
(does same as new gtp_pdp_newpdp() and doesn't allow for old_pdp to be
passed as parameter).

Fixes: OS#2873
Change-Id: I653cbdc185165592d985e3efab6e3f1add97877b
M gtp/gtp.c
M gtp/gtp.h
M gtp/pdp.c
M gtp/pdp.h
5 files changed, 90 insertions(+), 37 deletions(-)

  git pull ssh:// refs/changes/96/14296/2
To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I653cbdc185165592d985e3efab6e3f1add97877b
Gerrit-Change-Number: 14296
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list