Change in osmo-ggsn[master]: ggsn: Start gtp retrans timer during startup

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 31 14:25:57 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14201 )

Change subject: ggsn: Start gtp retrans timer during startup
......................................................................

ggsn: Start gtp retrans timer during startup

This timer was added in osmo-ggsn.git
dda21ed7d4a897c9284c69175d0da598598eae40,
but it was never initially started since it was introducing, and as a
result retransmissions never being triggered.

Also as a consequence, gtp_retrans is never called. That function is
responsible from triggering retransmissions and to free old responses
waiting in the resp queue (to check for duplicates). Since it's never
called, the retransmit resp queue will grow over time.

Fixes: dda21ed7d4a897c9284c69175d0da598598eae40
Fixes: OS#3997
Change-Id: Ie4adc52829446539fbbb5e9e0cf75a04f91c7eea
---
M ggsn/ggsn.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 6306924..9b45109 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -1022,6 +1022,7 @@
 
 	/* Start GTP re-transmission timer */
 	osmo_timer_setup(&ggsn->gtp_timer, ggsn_gtp_tmr_cb, ggsn);
+	ggsn_gtp_tmr_start(ggsn);
 
 	gtp_set_cb_data_ind(ggsn->gsn, encaps_tun);
 	gtp_set_cb_delete_context(ggsn->gsn, delete_context);

-- 
To view, visit https://gerrit.osmocom.org/14201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4adc52829446539fbbb5e9e0cf75a04f91c7eea
Gerrit-Change-Number: 14201
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/562ec9eb/attachment.html>


More information about the gerrit-log mailing list