Change in osmo-ggsn[master]: gtp: Document spec reasoning drop of Rx DeleteCtxReq

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 31 14:20:06 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14282 )

Change subject: gtp: Document spec reasoning drop of Rx DeleteCtxReq
......................................................................

gtp: Document spec reasoning drop of Rx DeleteCtxReq

Change-Id: I563fc0b48595d71ebdf56a50f4e9984eee423676
---
M gtp/gtp.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/gtp/gtp.c b/gtp/gtp.c
index b98fba0..430eeb4 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2613,6 +2613,14 @@
 		gtpie_gettv1(ie, GTPIE_TEARDOWN, 0, &teardown);
 
 		if (!teardown) {
+			/* TS 29.060 section 7.3.5: If a GSN receives a Delete PDP context
+			 * without a Teardown Indicator or with a Teardown Indicator with
+			 * value set to "0" and only that PDP context is active for a PDN
+			 * connection, then the GSN shall ignore the message.  (Note:
+			 * This is symptom of a race condition. The reliable delivery of
+			 * signalling messages will eventually lead to a consistent
+			 * situation, allowing the teardown of the PDP context.)
+			 */
 			for (n = 0; n < PDP_MAXNSAPI; n++)
 				if (linked_pdp->secondary_tei[n])
 					count++;

-- 
To view, visit https://gerrit.osmocom.org/14282
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I563fc0b48595d71ebdf56a50f4e9984eee423676
Gerrit-Change-Number: 14282
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190531/289d59d4/attachment.html>


More information about the gerrit-log mailing list