Change in osmo-ggsn[master]: ggsn: Fix undefined behaviour shifting beyond sign bit

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 30 16:31:27 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14287 )

Change subject: ggsn: Fix undefined behaviour shifting beyond sign bit
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14287/2/ggsn/ggsn_vty.c
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/14287/2/ggsn/ggsn_vty.c@657
PS2, Line 657: UINT32_C
Never seen that macro before, but it should be the same as:

  (uint32_t) 1 << i



-- 
To view, visit https://gerrit.osmocom.org/14287
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869
Gerrit-Change-Number: 14287
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 30 May 2019 16:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190530/383e3a9e/attachment.html>


More information about the gerrit-log mailing list