Change in osmo-ggsn[master]: ggsn: Fix undefined behaviour shifting beyond sign bit

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 30 15:29:50 UTC 2019


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/14287


Change subject: ggsn: Fix undefined behaviour shifting beyond sign bit
......................................................................

ggsn: Fix undefined behaviour shifting beyond sign bit

Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869
---
M ggsn/ggsn_vty.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/87/14287/1

diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c
index 3f012d2..9101361 100644
--- a/ggsn/ggsn_vty.c
+++ b/ggsn/ggsn_vty.c
@@ -654,9 +654,9 @@
 		vty_out(vty, "  ipdown-script %s%s", apn->tun.cfg.ipdown_script, VTY_NEWLINE);
 
 	for (i = 0; i < 32; i++) {
-		if (!(apn->cfg.apn_type_mask & (1 << i)))
+		if (!(apn->cfg.apn_type_mask & (UINT32_C(1) << i)))
 			continue;
-		vty_out(vty, "  type-support %s%s", get_value_string(pdp_type_names, (1 << i)),
+		vty_out(vty, "  type-support %s%s", get_value_string(pdp_type_names, (UINT32_C(1) << i)),
 			VTY_NEWLINE);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/14287
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869
Gerrit-Change-Number: 14287
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190530/33a586d8/attachment.html>


More information about the gerrit-log mailing list