Change in osmo-msc[master]: libmsc/msc_vty.c: do not abuse strlen() to check char buffers

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 29 15:40:34 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/14261


Change subject: libmsc/msc_vty.c: do not abuse strlen() to check char buffers
......................................................................

libmsc/msc_vty.c: do not abuse strlen() to check char buffers

In the most cases we need to check whether particular char buffer
is empty or not. Using strlen() for that involves more CPU power,
so let's just check the first character against '\0'.

Change-Id: I8728876b80c870e82247e6e56f719e10ed322a95
---
M src/libmsc/msc_vty.c
1 file changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/61/14261/1

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 5b0cfc4..8a976cb 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -793,11 +793,11 @@
 {
 	char buf[128];
 
-	if (strlen(vsub->name)) {
+	if (vsub->name[0] != '\0') {
 		MSC_VTY_DUMP(vty, offset, "Name: '%s'%s",
 			     vsub->name, VTY_NEWLINE);
 	}
-	if (strlen(vsub->msisdn)) {
+	if (vsub->msisdn[0] != '\0') {
 		MSC_VTY_DUMP(vty, offset, "MSISDN: %s%s",
 			     vsub->msisdn, VTY_NEWLINE);
 	}
@@ -873,8 +873,7 @@
 		     osmo_fsm_inst_state_name(vsub->sgs_fsm),
 		     VTY_NEWLINE);
 	MSC_VTY_DUMP(vty, offset, "SGs-MME: %s%s",
-		     strlen(vsub->sgs.mme_name) ?
-		             vsub->sgs.mme_name : "(none)",
+		     vsub->sgs.mme_name[0] != '\0' ? vsub->sgs.mme_name : "(none)",
 		     VTY_NEWLINE);
 
 	MSC_VTY_DUMP(vty, offset, "Use count total: %d%s",

-- 
To view, visit https://gerrit.osmocom.org/14261
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8728876b80c870e82247e6e56f719e10ed322a95
Gerrit-Change-Number: 14261
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190529/24d82622/attachment.html>


More information about the gerrit-log mailing list