Change in osmo-msc[master]: libmsc/msc_vty.c: refactor 'show subscr / conn / trans' commands

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 29 15:07:47 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14069 )

Change subject: libmsc/msc_vty.c: refactor 'show subscr / conn / trans' commands
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/14069/3/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/14069/3/src/libmsc/msc_vty.c@717
PS3, Line 717: trans->msc_a->c.msub
> trans->msc_a is not checked for NULL, although the FIXME above says it could be NULL.
Oh, right! I will fix this FIXME ;)


https://gerrit.osmocom.org/#/c/14069/3/src/libmsc/msc_vty.c@826
PS3, Line 826: vsub->imeisv[0] != '\0'
> (Consistency: ->imei and ->imeisv have != \0, but ->name and ->msisdn above have strlen(). […]
In general, I am agree. I will switch them all to foo[0] != '\0', but in a separate change if you don't insist. This change is more about appearance...



-- 
To view, visit https://gerrit.osmocom.org/14069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e58b56204c3f3d019e8d4c3c96cefdbb4af4d47
Gerrit-Change-Number: 14069
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 29 May 2019 15:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190529/832e7928/attachment.html>


More information about the gerrit-log mailing list