Change in osmo-bts[master]: clear GPRS indicator in SI3 while PCU is disconnected

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 28 23:31:41 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10170 )

Change subject: clear GPRS indicator in SI3 while PCU is disconnected
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/10170/5/src/common/pcu_sock.c
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/#/c/10170/5/src/common/pcu_sock.c@602
PS5, Line 602: regenerate_si3_restoctets
I think this should be rather done in pcu_sock_accept(). This function should do what the name says - process TXT indications.



-- 
To view, visit https://gerrit.osmocom.org/10170
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6f5c636c0fe098ee31c280d4572a3f8122b44b
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <suraev at alumni.ntnu.no>
Gerrit-Comment-Date: Tue, 28 May 2019 23:31:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190528/160a2a7f/attachment.html>


More information about the gerrit-log mailing list