This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14221 ) Change subject: Extend BTS_Tests.ttcn with test for RSL channel activation with static MS Power ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn@2005 PS1, Line 2005: more_ies :={valueof(t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ms_power := ms_power}))} this looks a bit 'clumsy' in terms of stuffing a lot in a single line without good reason. I'd sugest to first define a derived template like template t_RSL_IE_MsPower() := t_RSL_IE(RSL_IE_MS_POWER ... and then use that, or simply split it in two lines: * first assigne the valueof(...) to a local variable * then pass that variable as f_est_dchan(more_ies := {my_var}); https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn@2013 PS1, Line 2013: l1_dl.payload.data_ind.payload[0] > I'v pretty much just copied what other tests do, I guess in this particular case there is no real ne […] agreed we can avoid going through decode + template match here. -- To view, visit https://gerrit.osmocom.org/14221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icecf18c77bfe8b049cc0896c4c5b441187be1c0e Gerrit-Change-Number: 14221 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Wild <ewild at sysmocom.de> Gerrit-Reviewer: Eric Wild <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Tue, 28 May 2019 17:03:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190528/b7c1f6ee/attachment.htm>