Change in osmo-ttcn3-hacks[master]: Extend BTS_Tests.ttcn with test for RSL channel activation with stati...

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 28 13:40:02 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14221 )

Change subject: Extend BTS_Tests.ttcn with test for RSL channel activation with static MS Power
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn@2013
PS1, Line 2013: l1_dl.payload.data_ind.payload[0]
There is a definition for that header in library/GSM_RR_Types.ttcn:

  type record SacchL1Header { ... };

and a ts_* template:

  template (value) SacchL1Header ts_SacchL1Header ...;

I think we can implement the tr_* (matching) version of this template, and use it here?


https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn@2015
PS1, Line 2015: 		}
I think you probably (I am not sure) need to add:

  setverdict(pass);

otherwise the test result is undefined?


https://gerrit.osmocom.org/#/c/14221/1/bts/BTS_Tests.ttcn@2021
PS1, Line 2021: 	}
+1 tab



-- 
To view, visit https://gerrit.osmocom.org/14221
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icecf18c77bfe8b049cc0896c4c5b441187be1c0e
Gerrit-Change-Number: 14221
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Wild <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 28 May 2019 13:40:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190528/6c1d9522/attachment.html>


More information about the gerrit-log mailing list