Change in osmo-bsc[master]: rx_fail_evt_rep(): Don't recycle variable

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 27 11:50:35 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14175 )

Change subject: rx_fail_evt_rep(): Don't recycle variable
......................................................................

rx_fail_evt_rep(): Don't recycle variable

the 'p_val' variable should represent he 'probabl cause value' and
nothing else.  Let's use other local variables for other things.

Change-Id: Ie79279fc1d42cd57e7478820493b250fe38c2f4f
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 240517b..bff6c12 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -368,8 +368,8 @@
 			  oh->length-sizeof(*foh));
 
 	if (TLVP_PRESENT(&tp, NM_ATT_ADD_TEXT)) {
-		p_val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT);
-		p_text = talloc_strndup(tall_bsc_ctx, (const char *) p_val,
+		const uint8_t *val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT);
+		p_text = talloc_strndup(tall_bsc_ctx, (const char *) val,
 					TLVP_LEN(&tp, NM_ATT_ADD_TEXT));
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/14175
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79279fc1d42cd57e7478820493b250fe38c2f4f
Gerrit-Change-Number: 14175
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190527/f246725e/attachment.html>


More information about the gerrit-log mailing list