Change in osmo-ttcn3-hacks[master]: bsc: Introduce Osmux infra and one test for osmo-bsc

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 26 09:21:58 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14105 )

Change subject: bsc: Introduce Osmux infra and one test for osmo-bsc
......................................................................


Patch Set 6: Code-Review+2

(3 comments)

sorry, I was somehow reading the code wrong. Please ignore previous comments. patch is fine!

https://gerrit.osmocom.org/#/c/14105/6/bsc-nat/BSC_MS_ConnectionHandler.ttcn
File bsc-nat/BSC_MS_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/14105/6/bsc-nat/BSC_MS_ConnectionHandler.ttcn@57
PS6, Line 57: use_osmux := false
> AFAIK, thhis should actually be part of the previous patch, hwere the new member is introduced. […]
Done


https://gerrit.osmocom.org/#/c/14105/6/bsc-nat/MSC_ConnectionHandler.ttcn
File bsc-nat/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/14105/6/bsc-nat/MSC_ConnectionHandler.ttcn@63
PS6, Line 63: 	use_osmux := false,
> same here (previous patch)
Done


https://gerrit.osmocom.org/#/c/14105/6/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/14105/6/msc/BSC_ConnectionHandler.ttcn@212
PS6, Line 212: 	use_osmux := false,
> same here (previous patch)
Done



-- 
To view, visit https://gerrit.osmocom.org/14105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If69c716dc06d61d810c32d1720a237c7535baca8
Gerrit-Change-Number: 14105
Gerrit-PatchSet: 6
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 26 May 2019 09:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190526/e0e89101/attachment.html>


More information about the gerrit-log mailing list