Change in libosmocore[master]: gsm0408/gsm0408_test.c: introduce BCD number encoding / decoding test

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 26 09:04:12 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14184 )

Change subject: gsm0408/gsm0408_test.c: introduce BCD number encoding / decoding test
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14184/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14184/3//COMMIT_MSG@10
PS3, Line 10: uncovered
I don't think you can use "uncovered" here.  "uncovered" has a meaning like "discovered".  I guess you have to write "did not have coverage by unit tests [yet]" or something along those lines.



-- 
To view, visit https://gerrit.osmocom.org/14184
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b2c330cf8ffe4427c0bee7d5f3b74be56ecd85d
Gerrit-Change-Number: 14184
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 26 May 2019 09:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190526/8fef0476/attachment.html>


More information about the gerrit-log mailing list