Change in osmo-pcu[master]: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat May 25 11:19:10 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14171 )

Change subject: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Finally! Thanks a lot for looking into this! A few days ago I faced this bug, when you can 'write' the VTY configuration, but then reading fails.

https://gerrit.osmocom.org/#/c/14171/1/src/gprs_bssgp_pcu.cpp
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/#/c/14171/1/src/gprs_bssgp_pcu.cpp@906
PS1, Line 906: 
Makes sense to OSMO_ASSERT(!bssgp_nsi) here.



-- 
To view, visit https://gerrit.osmocom.org/14171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa53ea54e9352577f6280ad7b9d1d9da9f57eaf
Gerrit-Change-Number: 14171
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 25 May 2019 11:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190525/6d559aa9/attachment.html>


More information about the gerrit-log mailing list