Change in osmo-pcu[master]: gprs_bssgp_pcu: make gprs_bssgp_ns_cb public

lynxis lazus gerrit-no-reply at
Sat May 25 03:57:31 UTC 2019

lynxis lazus has uploaded this change for review. (

Change subject: gprs_bssgp_pcu: make gprs_bssgp_ns_cb public

gprs_bssgp_pcu: make gprs_bssgp_ns_cb public

rename the function sgsn_ns_cb -> gprs_bssgp_ns_cb.
To allow writing and reading the same configuration, the pcu needs to register
all vty commands before reading the configuration. This callback
is required to register NS based vty commands

Related: OS#4024
Change-Id: I440c0df2e32fe22bf43288c00bb4aa3a0c6a3a51
M src/gprs_bssgp_pcu.cpp
M src/gprs_bssgp_pcu.h
2 files changed, 5 insertions(+), 2 deletions(-)

  git pull ssh:// refs/changes/70/14170/1

diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 9d02df6..50f10db 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -520,7 +520,7 @@
 	return 0;
-static int sgsn_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc, struct msgb *msg, uint16_t bvci)
+int gprs_bssgp_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc, struct msgb *msg, uint16_t bvci)
 	int rc = 0;
 	switch (event) {
@@ -913,7 +913,7 @@
 	the_pcu.bts = bts;
-	bssgp_nsi = gprs_ns_instantiate(&sgsn_ns_cb, tall_pcu_ctx);
+	bssgp_nsi = gprs_ns_instantiate(&gprs_bssgp_ns_cb, tall_pcu_ctx);
 	if (!bssgp_nsi) {
 		LOGP(DBSSGP, LOGL_ERROR, "Failed to create NS instance\n");
 		return NULL;
diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h
index e8ae1a9..f98e719 100644
--- a/src/gprs_bssgp_pcu.h
+++ b/src/gprs_bssgp_pcu.h
@@ -80,6 +80,9 @@
 		uint16_t nsvci, uint16_t bvci, uint16_t mcc, uint16_t mnc, bool mnc_3_digits,
 		uint16_t lac, uint16_t rac, uint16_t cell_id);
+int gprs_bssgp_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc,
+	       struct msgb *msg, uint16_t bvci);
 void gprs_bssgp_destroy(void);
 struct bssgp_bvc_ctx *gprs_bssgp_pcu_current_bctx(void);

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I440c0df2e32fe22bf43288c00bb4aa3a0c6a3a51
Gerrit-Change-Number: 14170
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list