Change in osmo-trx[master]: Add rate_ctr support to store/retrieve SDR errors through VTY

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 24 20:12:38 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14167 )

Change subject: Add rate_ctr support to store/retrieve SDR errors through VTY
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14167/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/14167/1//COMMIT_MSG@18
PS1, Line 18:    device:rx_underruns:          0 (0/s 0/m 0/h 0/d) Number of Rx underruns
            :     device:rx_overruns:          0 (0/s 0/m 0/h 0/d) Number of Rx overruns
do we have a clear definition of what those are? I think the  terminology is not entirely obvious.  For Tx: Ok, an unterrun means the hardware wanted to transmit but didn't have data.  For Rx: an overrun means that some data was lost because we didn't consume it fast enough.  But what's a "rx underrun" ?



-- 
To view, visit https://gerrit.osmocom.org/14167
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78b158141697e5714d04db8b9ccc96f31f34f439
Gerrit-Change-Number: 14167
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 24 May 2019 20:12:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190524/bd457112/attachment.html>


More information about the gerrit-log mailing list