Change in osmocom-bb[master]: common/sap_fsm.c: fix missing pointer dereference

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 24 16:04:09 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14135 )

Change subject: common/sap_fsm.c: fix missing pointer dereference
......................................................................

common/sap_fsm.c: fix missing pointer dereference

sap_fsm.c: In function ‘sap_negotiate_msg_size’: sap_fsm.c:103:15:
warning: passing argument 1 of ‘__bswap_16’ makes integer from pointer
without a cast [-Wint-conversion]:

  size = ntohs((uint16_t *) param->value);
               ^~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1
---
M src/host/layer23/src/common/sap_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/host/layer23/src/common/sap_fsm.c b/src/host/layer23/src/common/sap_fsm.c
index f07488f..2265891 100644
--- a/src/host/layer23/src/common/sap_fsm.c
+++ b/src/host/layer23/src/common/sap_fsm.c
@@ -100,7 +100,7 @@
 	}
 
 	/* Parse MaxMsgSize suggested by server */
-	size = ntohs((uint16_t *) param->value);
+	size = osmo_load16be(param->value);
 	if (size > SAP_MAX_MSG_SIZE) {
 		cause = "suggested MaxMsgSize is too big for us";
 		goto error;

-- 
To view, visit https://gerrit.osmocom.org/14135
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie58af6162c67ae377809b42daa897ca3f3d72af1
Gerrit-Change-Number: 14135
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Assignee: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: fixeria <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190524/e570cb4c/attachment.html>


More information about the gerrit-log mailing list