Change in osmo-bsc[master]: chan_alloc: Don't include CBCH channels in load computation

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 24 09:12:58 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14152 )

Change subject: chan_alloc: Don't include CBCH channels in load computation
......................................................................

chan_alloc: Don't include CBCH channels in load computation

When displaying the channel (lchan) load, we are interested in the
dedicated channels as available for communication with mobile
stations.  If CBCH is enabled, it "steals" one of the SDCCH slots,
so we have to exclude this channel from the count of available
dedicated channels.

Before this patch, A CBCH would show up as "in use" dedicated channel
(so both the total and the in_use count were incremented).

After this patch, neither "total" nor "use" are affected; The CBCH
slot is completely excluded from load statistics.

Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index 9c43414..7f0aa31 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -59,6 +59,10 @@
 				continue;
 
 			ts_for_each_lchan(lchan, ts) {
+				/* don't even count CBCH slots in total */
+				if (lchan->type == GSM_LCHAN_CBCH)
+					continue;
+
 				pl->total++;
 
 				switch (lchan->fi->state) {

-- 
To view, visit https://gerrit.osmocom.org/14152
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
Gerrit-Change-Number: 14152
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190524/fde4544d/attachment.html>


More information about the gerrit-log mailing list