Change in osmo-bts[master]: rsl: Implement parsing of BS Power Control message

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 24 09:11:12 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14156 )

Change subject: rsl: Implement parsing of BS Power Control message
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14156/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/14156/1/src/common/rsl.c@1603
PS1, Line 1603: 	LOGPLCHAN(lchan, DRSL, LOGL_NOTICE, "BS POWER CONTROL to -%u dBm\n", (lchan->bs_power & 0xF)*2);
> this mask and *2 here probably deserves some comment.
I moved the computation to a function with spec reference



-- 
To view, visit https://gerrit.osmocom.org/14156
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id144a7e468f730e3cdaefa4cf2ad51c6106310a2
Gerrit-Change-Number: 14156
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 24 May 2019 09:11:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190524/70779ad2/attachment.html>


More information about the gerrit-log mailing list