Change in osmo-bts[master]: sysmo: Fix "nominal power" / BS power display in VTY

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 23 16:33:16 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14137 )

Change subject: sysmo: Fix "nominal power" / BS power display in VTY
......................................................................

sysmo: Fix "nominal power" / BS power display in VTY

The function get_p_max_out_mdBm() returns a value in 1/1000th of dBm,
"milli-dBm", while trx->nominal_power is only whole dBm.  We were
missing the required divider of 1000 ever since Change-Id
Ieff75d5becaa80a2097b6e744c75c2d16259c9a4 was merged in February 2017.

The good news is that this really only affected the VTY output and
not any actual operational aspect of the system.

Change-Id: If92d0b15c48dafc63776b82c7ff5f3c2b3505f68
Closes: SYS#4570
---
M src/osmo-bts-sysmo/l1_if.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved
  roh: Looks good to me, approved



diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 87cf25a..6f61c67 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -1883,7 +1883,7 @@
 			LOGP(DL1C, LOGL_NOTICE, "Cannot determine nominal "
 			     "transmit power. Assuming 23dBm.\n");
 		}
-		bts->c0->nominal_power = rc;
+		bts->c0->nominal_power = rc / 1000;
 	}
 
 	hdl = pinst->u.sysmobts.hdl;

-- 
To view, visit https://gerrit.osmocom.org/14137
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If92d0b15c48dafc63776b82c7ff5f3c2b3505f68
Gerrit-Change-Number: 14137
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190523/ec0e146d/attachment.html>


More information about the gerrit-log mailing list