Change in openbsc[master]: mgcp: Handle CI and X-Osmux param name as case insensitive

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu May 23 12:42:58 UTC 2019


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/14131

to look at the new patch set (#4).

Change subject: mgcp: Handle CI and X-Osmux param name as case insensitive
......................................................................

mgcp: Handle CI and X-Osmux param name as case insensitive

RFC3435 states most text (except SDP) must be handled as case
insensitive.

Since we are no longer using strstr(msg->l2h), we need to iterate per
line and call related extract/handle function for that line.

Call to bsc_mgcp_osmux_confirm() is left at the end because it needs to
be called too in case no matching line is found. In that case, it will
release the CID. Similar stuff ocurrs for bsc_mgcp_extract_ci().

Related: OS#4001
Change-Id: Iadc004064a5a237c93009f242cb943ebc4d2d7e6
---
M openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c
M openbsc/tests/bsc-nat/bsc_nat_test.c
2 files changed, 62 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/31/14131/4
-- 
To view, visit https://gerrit.osmocom.org/14131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iadc004064a5a237c93009f242cb943ebc4d2d7e6
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190523/db531b4f/attachment.html>


More information about the gerrit-log mailing list