Change in osmo-bts[master]: RSL: Fix off-by-one error when parsing SACCH INFO IE in RSL CHAN ACT

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 21 18:14:19 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14087 )

Change subject: RSL: Fix off-by-one error when parsing SACCH INFO IE in RSL CHAN ACT
......................................................................

RSL: Fix off-by-one error when parsing SACCH INFO IE in RSL CHAN ACT

This off-by-one error in length verification caused all SACCH INFO IE
to be deemed invalid and hence any RSL CHAN ACT with that IE to be
rejected.

Change-Id: I6436caf5c2caefbf7c089d66e37d8d1babe1c24e
Related: OS#3750
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index b02f4e6..76aaef3 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1133,7 +1133,7 @@
 			lapdm_ui_prefix_lchan(lchan, cur, osmo_si, si_len);
 
 			cur += si_len;
-			if (cur >= val + tot_len) {
+			if (cur > val + tot_len) {
 				LOGP(DRSL, LOGL_ERROR, "Error parsing SACCH INFO IE\n");
 				rsl_tx_error_report(msg->trx, RSL_ERR_IE_CONTENT, &dch->chan_nr,
 						    NULL, msg);

-- 
To view, visit https://gerrit.osmocom.org/14087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6436caf5c2caefbf7c089d66e37d8d1babe1c24e
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190521/a792682e/attachment.html>


More information about the gerrit-log mailing list