Change in osmo-bts[master]: RSL: Reject RLL messages for lchans that are not active yet

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 21 18:14:19 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14085 )

Change subject: RSL: Reject RLL messages for lchans that are not active yet
......................................................................

RSL: Reject RLL messages for lchans that are not active yet

The Radio Link Layer (RLL) messages only make sense when a given
logical channel is active.  If it isn't active, let's reject the
messages with an RSL ERROR REPORT with cause "Message sequence error",
wich according to spec means:

"A message with an existing message type which is not possible according
 to the specification and to the state of the BTS is erroneous."

Related: OS#3750
Change-Id: I68dbb622aeaee657471664cdc0b69c2ac316d77e
---
M src/common/rsl.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 0fe50e0..b02f4e6 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2559,6 +2559,14 @@
 		return rsl_reject_unknown_lchan(msg);
 	}
 
+	if (lchan->state != LCHAN_S_ACTIVE) {
+		LOGPLCHAN(lchan, DRLL, LOGL_NOTICE, "Rx RLL %s for lchan which isn't active\n",
+			rsl_msg_name(rh->c.msg_type));
+		rsl_tx_error_report(trx, RSL_ERR_MSG_SEQ, &rh->chan_nr, &rh->link_id, msg);
+		msgb_free(msg);
+		return -1;
+	}
+
 	DEBUGP(DRLL, "%s Rx RLL %s Abis -> LAPDm\n", gsm_lchan_name(lchan),
 		rsl_msg_name(rh->c.msg_type));
 

-- 
To view, visit https://gerrit.osmocom.org/14085
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68dbb622aeaee657471664cdc0b69c2ac316d77e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190521/ddf3cf5d/attachment.html>


More information about the gerrit-log mailing list