Change in osmo-bsc[master]: Make sure to default to AMR octet-aligned mode

Harald Welte gerrit-no-reply at
Sun May 19 07:18:28 UTC 2019

Harald Welte has submitted this change and it was merged. ( )

Change subject: Make sure to default to AMR octet-aligned mode

Make sure to default to AMR octet-aligned mode

In Change-Id If6d40b2407b87aad2227ea7f15533ef01a3771b3 we introduced
the support for both octet-aligned and bandwidth-efficient mode, and
added a related VTY option about it.

However, we accidentially also changed the default behavior.  Without
any explicit configuration, we should behave just like we behaved all
those years before: Continue with octet-aligned mode.

Change-Id: I8b6fd8bec05b35d84ad16275d84f9d363e238d2b
Closes: OS#4002
M src/osmo-bsc/osmo_bsc_msc.c
1 file changed, 1 insertion(+), 0 deletions(-)

  tnt: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c
index 4df1ce4..6a6b1a9 100644
--- a/src/osmo-bsc/osmo_bsc_msc.c
+++ b/src/osmo-bsc/osmo_bsc_msc.c
@@ -94,6 +94,7 @@
 	/* Defaults for the audio setup */
 	msc_data->amr_conf.m5_90 = 1;
+	msc_data->amr_octet_aligned = true;
 	/* Allow the full set of possible codecs by default */
 	msc_data->audio_length = 5;

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b6fd8bec05b35d84ad16275d84f9d363e238d2b
Gerrit-Change-Number: 14050
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: tnt <tnt at>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list