Change in osmo-sgsn[master]: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat May 18 13:52:43 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13929 )

Change subject: libgtp: don't call sgsn_pdp_ctx_free() with NULL pdp
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/13929/4/src/gprs/sgsn_libgtp.c
File src/gprs/sgsn_libgtp.c:

https://gerrit.osmocom.org/#/c/13929/4/src/gprs/sgsn_libgtp.c@550
PS4, Line 550: pdp
Newline is missing here. Also, is it a normal and expected event in general? If not, we should use LOGL_NOTICE, or even LOGL_ERROR.



-- 
To view, visit https://gerrit.osmocom.org/13929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I184dcce27b26104c61d80b2d910388d5d3323def
Gerrit-Change-Number: 13929
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 18 May 2019 13:52:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190518/71980493/attachment.html>


More information about the gerrit-log mailing list