Change in osmo-msc[master]: bssap: Detect BSC Osmux support on RESET (ACK) recv

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 14 15:30:11 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/14039 )

Change subject: bssap: Detect BSC Osmux support on RESET (ACK) recv
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c
File src/libmsc/ran_peer.c:

https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c@134
PS2, Line 134: msg->l3h
It probably makes sense to OSMO_ASSERT(msg) here, as we receive it from the FSM handlers.


https://gerrit.osmocom.org/#/c/14039/2/src/libmsc/ran_peer.c@137
PS2, Line 137: Failed parsing TLV
Does it make sense to continue execution of this function in this case?



-- 
To view, visit https://gerrit.osmocom.org/14039
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4f33da9b414ab194098755d2c5be85e1fce5d31
Gerrit-Change-Number: 14039
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 14 May 2019 15:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190514/0f35eaea/attachment.html>


More information about the gerrit-log mailing list