Change in osmo-ggsn[master]: osmo-ggsn: print requested / actual APN in PDP info

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon May 13 16:01:59 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14016 )

Change subject: osmo-ggsn: print requested / actual APN in PDP info
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14016/1/ggsn/ggsn_vty.c
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/14016/1/ggsn/ggsn_vty.c@752
PS1, Line 752: 	vty_out(vty, " APN requested: %s%s", apn_name ? name_buf : "(NONE)", VTY_NEWLINE);
Probably makes sense to swap both (chronological order: first user requested X, then we actually assigned Y).



-- 
To view, visit https://gerrit.osmocom.org/14016
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbe195f64e5b83d5158c175aad2e81ba2487850
Gerrit-Change-Number: 14016
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 May 2019 16:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/bccc229f/attachment.html>


More information about the gerrit-log mailing list