Change in osmo-msc[master]: tests/.../Makefile.am avoid redundant linkage with librt

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon May 13 12:47:04 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/14012 )

Change subject: tests/.../Makefile.am avoid redundant linkage with librt
......................................................................

tests/.../Makefile.am avoid redundant linkage with librt

The librt is required for old glibc < 2.17 to get clock_gettime().
Since we do check the availability of this function libosmocore
and conditionally link it against librt, there is no need to do
such unconditional and redundant linkage here.

Change-Id: If587d16d2db677b97e3a0641027eb735af9c9c30
---
M tests/msc_vlr/Makefile.am
M tests/sms_queue/Makefile.am
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/msc_vlr/Makefile.am b/tests/msc_vlr/Makefile.am
index 29c5fb1..f9a9224 100644
--- a/tests/msc_vlr/Makefile.am
+++ b/tests/msc_vlr/Makefile.am
@@ -42,7 +42,6 @@
 	$(LIBOSMOGSUPCLIENT_LIBS) \
 	$(LIBRARY_GSM) \
 	-ldbi \
-	-lrt \
 	$(NULL)
 
 noinst_HEADERS = \
diff --git a/tests/sms_queue/Makefile.am b/tests/sms_queue/Makefile.am
index 81e017b..80189c7 100644
--- a/tests/sms_queue/Makefile.am
+++ b/tests/sms_queue/Makefile.am
@@ -45,7 +45,6 @@
 	$(LIBOSMOGSUPCLIENT_LIBS) \
 	$(LIBRARY_GSM) \
 	-ldbi \
-	-lrt \
 	$(NULL)
 
 sms_queue_test_LDFLAGS = \

-- 
To view, visit https://gerrit.osmocom.org/14012
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If587d16d2db677b97e3a0641027eb735af9c9c30
Gerrit-Change-Number: 14012
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/0efbda7b/attachment.html>


More information about the gerrit-log mailing list