Change in osmo-ggsn[master]: osmo-ggsn: add VTY command to show PDP context by IPv4

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon May 13 09:08:45 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/14010 )

Change subject: osmo-ggsn: add VTY command to show PDP context by IPv4
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14010/2/ggsn/ggsn_vty.c
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/#/c/14010/2/ggsn/ggsn_vty.c@785
PS2, Line 785: 	"show pdp-context ggsn NAME ipv4 A.B.C.D",
> Why adding a specific ggsn here? Other show pdp-context don't require it, so I'd stick to same forma […]
Oh I actually see show_pdpctx_apn_cmd has already same format, so fine then.



-- 
To view, visit https://gerrit.osmocom.org/14010
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad60de34c562803a1a1fc024287d1a60e071afab
Gerrit-Change-Number: 14010
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 May 2019 09:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/7dc0eb68/attachment.html>


More information about the gerrit-log mailing list