Change in osmo-hlr[master]: Create subscribers on demand

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon May 13 08:12:05 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13713 )

Change subject: Create subscribers on demand
......................................................................


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/#/c/13713/6/src/hlr.c
File src/hlr.c:

https://gerrit.osmocom.org/#/c/13713/6/src/hlr.c@153
PS6, Line 153: generate_new_msisdn
Let's follow the style of memcmp() here: dst, src, len.


https://gerrit.osmocom.org/#/c/13713/6/src/hlr.c@153
PS6, Line 153:  {
Also, please add a new line.


https://gerrit.osmocom.org/#/c/13713/6/src/hlr.c@155
PS6, Line 155: rand_buf
In scope of this function, it makes sense to ASSERT() given len <= sizeof(rand_buf). I guess Coverity may fail to detect that VTY actually limits the length to 15.



-- 
To view, visit https://gerrit.osmocom.org/13713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 6
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 May 2019 08:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/f4e85de3/attachment.html>


More information about the gerrit-log mailing list