Change in osmo-hlr[master]: db_hlr.c: db_subscr_create(): add flags argument

osmith gerrit-no-reply at lists.osmocom.org
Mon May 13 06:50:57 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/13711 )

Change subject: db_hlr.c: db_subscr_create(): add flags argument
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/13711/4/src/db_hlr.c
File src/db_hlr.c:

https://gerrit.osmocom.org/#/c/13711/4/src/db_hlr.c@67
PS4, Line 67: 	if (!db_bind_int(stmt, "$nam_ps", flags & DB_SUBSCR_FLAG_NAM_PS))
I just noticed, that this leads to writing "2" in the database. I'll update the patch.



-- 
To view, visit https://gerrit.osmocom.org/13711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6dd85387723dab5487c53b33d2d9ec6d05d006
Gerrit-Change-Number: 13711
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 May 2019 06:50:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190513/36bc901d/attachment.html>


More information about the gerrit-log mailing list