Change in libosmocore[master]: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun May 12 10:22:09 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13973 )

Change subject: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()
......................................................................


Patch Set 2: Code-Review-1

keeping the VTY context a separate context *not* underneath the applications global talloc context is actually a feature that was introduced intentionally.

The point is that VTY is a heavy user of talloc, and it generates quite lengthy reports.  By keeping the VTY alloctaions separate, we ensure that the normal talloc_report of the application context is not full of "vty spam" that we're not really interested.  OpenBSC (and everything that we created as derivatife of openbsc.git later on) use different signals (SIGUSR1 vs SIGUSR2) to get the report either with or without VTY.

I'm not saying this is set in stone, but there is some logic to it and we should be careful about changing this.

I would rather want to move the SIGUSR* handling into libosmocore to avoid replicating this all over the place.  This way we can ensure consistent behavior with regard to the VTY...


-- 
To view, visit https://gerrit.osmocom.org/13973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65d71f8fc943e103b53b784f690ed56a6e373e3f
Gerrit-Change-Number: 13973
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sun, 12 May 2019 10:22:09 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190512/7527a66a/attachment.html>


More information about the gerrit-log mailing list