Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat May 11 14:37:52 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13963 )

Change subject: libmsc: Make sure to not dereference a NULL trans
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_04_08_cc.c
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_04_08_cc.c@1891
PS1, Line 1891: LOG_TRANS_CAT
I still think that it makes more sense to use generic LOGP(ss, cat, ...) if we 100% sure that trans is NULL. Neither LOG_TRANS_CAT(), not NULL-safe LOG_TRANS() would give us any useful information in such cases...


https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_04_08_cc.c@2124
PS1, Line 2124: LOG_TRANS_CAT
Same here.


https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_09_11.c
File src/libmsc/gsm_09_11.c:

https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_09_11.c@148
PS1, Line 148: LOG_MSC_A
Neels has submitted a change that adds DSS logging category, please see: https://gerrit.osmocom.org/#/c/osmo-msc/+/13942/.



-- 
To view, visit https://gerrit.osmocom.org/13963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia14bd28e1db570c487ad8e90e29a69208e2226f2
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 11 May 2019 14:37:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190511/ee0fea3c/attachment.html>


More information about the gerrit-log mailing list