This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13985 ) Change subject: SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_attach_rau_a_b ...................................................................... SGSN_Tests: fix regression in f_send_l3_gmm_llc() which breaks TC_attach_rau_a_b The gb_index was forgotten to given to the new function f_send_l3(). All testcases which only used the default BSSGB connection #0 continued to work, but the TC_attach_rau_a_b is the only testcase which uses #0 and #1 at the same time. Fixes: a05b80792266 ("sgsn: Add TC_llc_null to test if SGSN survives a LLC NULL packet") Change-Id: Ie3dd8c613d3b3440447a282dc4545078cb927274 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 6665dc0..d081360 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -385,7 +385,7 @@ var octetstring l3_enc := enc_PDU_L3_MS_SGSN(valueof(l3_mo)); var BIT4 sapi := f_llc_sapi_by_l3_mo(valueof(l3_mo)); var integer n_u := f_llc_get_n_u_tx(llc[bit2int(sapi)]); - f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u)); + f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u), gb_index); } altstep as_mm_identity(integer gb_idx := 0) runs on BSSGP_ConnHdlr { -- To view, visit https://gerrit.osmocom.org/13985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie3dd8c613d3b3440447a282dc4545078cb927274 Gerrit-Change-Number: 13985 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190511/58a293ad/attachment.htm>