Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 10 22:38:18 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13860 )

Change subject: SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value
......................................................................

SGSN_Tests: Introduce NUM_GB to avoid '3' as magic value

Change-Id: I28b7dd26c5c129ec41c6349de9ddc9ef0ffee8ac
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index d87c09d..6665dc0 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -84,9 +84,10 @@
 	BssgpConfig cfg
 };
 
-type record length(3) of GbInstance GbInstances;
-type record length(3) of NSConfiguration NSConfigurations;
-type record length(3) of BssgpCellId BssgpCellIds;
+const integer NUM_GB := 3;
+type record length(NUM_GB) of GbInstance GbInstances;
+type record length(NUM_GB) of NSConfiguration NSConfigurations;
+type record length(NUM_GB) of BssgpCellId BssgpCellIds;
 
 type component test_CT {
 	var GbInstances g_gb;

-- 
To view, visit https://gerrit.osmocom.org/13860
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I28b7dd26c5c129ec41c6349de9ddc9ef0ffee8ac
Gerrit-Change-Number: 13860
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/5a7248a7/attachment.html>


More information about the gerrit-log mailing list