Change in osmo-msc[master]: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 10 22:05:42 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13980 )

Change subject: libmsc/rtp_stream.c: prevent potential NULL-pointer dereference
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13980/1/src/libmsc/rtp_stream.c
File src/libmsc/rtp_stream.c:

https://gerrit.osmocom.org/#/c/13980/1/src/libmsc/rtp_stream.c@143
PS1, Line 143: crcx_info = osmo_mgcpc_ep_ci_get_rtp_info(rtps->ci);
             : 		OSMO_ASSERT(crcx_info != NULL);
I'd be careful here. ASSERT is fine for things that really should never fail in a production system.  If there is a valid situation where osmo_mgcpc_ep_ci_get_rtp_info might return NULL, then we have to deal with it at runtime rather than taking the entire network down and terminating the process.



-- 
To view, visit https://gerrit.osmocom.org/13980
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie80b9fae490acc9ee8de742e35b6ef59c4388f57
Gerrit-Change-Number: 13980
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 10 May 2019 22:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/d3f67df8/attachment.html>


More information about the gerrit-log mailing list