Change in osmo-msc[master]: libmsc: Make sure to not dereference a NULL trans

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 10 20:26:38 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13963 )

Change subject: libmsc: Make sure to not dereference a NULL trans
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_04_08_cc.c
File src/libmsc/gsm_04_08_cc.c:

https://gerrit.osmocom.org/#/c/13963/1/src/libmsc/gsm_04_08_cc.c@1891
PS1, Line 1891: LOG_TRANS_CAT
> Alternatively, we can make LOG_TRANS() macro NULL-safe: […]
To keep the discussion in a proper place:

(03:18:04) fixeria: maybe we should rather make LOG_TRANS() NULL-safe?
(03:18:39) tnt: fixeria: I thought about it, but then you basically have to give up on using the right log category.
(03:19:42) tnt: (in trans_alloc you can find it out since you have the param ... but in all the other case you just have NULL ... )



-- 
To view, visit https://gerrit.osmocom.org/13963
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia14bd28e1db570c487ad8e90e29a69208e2226f2
Gerrit-Change-Number: 13963
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 10 May 2019 20:26:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/9e75cd0c/attachment.html>


More information about the gerrit-log mailing list