Change in libosmo-sccp[master]: osmo-stp: track the use of NULL talloc-context

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 10 18:05:34 UTC 2019


Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13972


Change subject: osmo-stp: track the use of NULL talloc-context
......................................................................

osmo-stp: track the use of NULL talloc-context

Change-Id: I89e7faf8469f5eba9599c9cbc1fec4fe583e7a13
---
M stp/stp_main.c
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/72/13972/1

diff --git a/stp/stp_main.c b/stp/stp_main.c
index 3127321..04bca7c 100644
--- a/stp/stp_main.c
+++ b/stp/stp_main.c
@@ -160,6 +160,9 @@
 {
 	int rc;
 
+	/* Track the use of NULL memory context */
+	talloc_enable_null_tracking();
+
 	tall_stp_ctx = talloc_named_const(NULL, 1, "osmo-stp");
 	msgb_talloc_ctx_init(tall_stp_ctx, 0);
 	osmo_init_logging2(tall_stp_ctx, &log_info);
@@ -230,5 +233,13 @@
 	talloc_report_full(tall_stp_ctx, stderr);
 	talloc_free(tall_stp_ctx);
 
+	/* FIXME: VTY code still uses NULL-context */
+	talloc_free(tall_vty_ctx);
+
+	/* Report state of NULL talloc-context, then free,
+	 * so both ASAN and Valgrind are happy... */
+	talloc_report_full(NULL, stderr);
+	talloc_disable_null_tracking();
+
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/13972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89e7faf8469f5eba9599c9cbc1fec4fe583e7a13
Gerrit-Change-Number: 13972
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/9a062118/attachment.html>


More information about the gerrit-log mailing list