Change in osmo-hlr[master]: Create subscribers on demand

osmith gerrit-no-reply at
Fri May 10 12:18:55 UTC 2019

osmith has posted comments on this change. ( )

Change subject: Create subscribers on demand

Patch Set 3:

File src/hlr.h:
PS3, Line 63: uint8_t
> Unsigned int. No need to use fixed-size type here.
File src/hlr.c:
PS3, Line 158: int
> Unsigned int.
PS3, Line 173: rand_msisdn_len
> Feel free to inverse this statement, so this would allow to reduce code nesting: […]
Good idea, done.
File src/hlr_vty.c:
PS3, Line 358: 3
> AFAIR, a single digit is also a valid MSISDN ;)
Yes, but then the HLR would run out of available msisdns very fast, so I don't think there's practical value in allowing less than three digits.

Unless you want to set up a 'first 10 people who join the network can use it for free' type of thing ;D

So I would keep the 3 there, to make it harder to misconfigure the feature, and change it only if somebody has a real world use case.

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: osmith <osmith at>
Gerrit-Comment-Date: Fri, 10 May 2019 12:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list