Change in osmo-hlr[master]: db_hlr.c: db_subscr_create(): add flags argument

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri May 10 11:29:57 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13711 )

Change subject: db_hlr.c: db_subscr_create(): add flags argument
......................................................................


Patch Set 3:

(4 comments)

Looks great in general, just a few final notes.

https://gerrit.osmocom.org/#/c/13711/3/src/db.h
File src/db.h:

https://gerrit.osmocom.org/#/c/13711/3/src/db.h@121
PS3, Line 121: DB_SUBSCR_FLAG_NONE
I don't think we really need this one.


https://gerrit.osmocom.org/#/c/13711/3/src/db.h@122
PS3, Line 122: 0x01
Let's have the values in more common form for flags: (1 << 1).


https://gerrit.osmocom.org/#/c/13711/3/src/db.h@123
PS3, Line 123: 0x02
And here (1 << 2), so this is much cleaner that the new flag would be (1 << 3), and not 0x03.


https://gerrit.osmocom.org/#/c/13711/3/tests/db/db_test.c
File tests/db/db_test.c:

https://gerrit.osmocom.org/#/c/13711/3/tests/db/db_test.c@458
PS3, Line 458: DB_SUBSCR_FLAG_NONE
We can just use 0x00 or 0 here.



-- 
To view, visit https://gerrit.osmocom.org/13711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6dd85387723dab5487c53b33d2d9ec6d05d006
Gerrit-Change-Number: 13711
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2019 11:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/07b8e13f/attachment.html>


More information about the gerrit-log mailing list