Change in osmo-ttcn3-hacks[master]: ggsn: Verify that there are no duplicate PCO protocolIDs

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri May 10 10:46:03 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13563 )

Change subject: ggsn: Verify that there are no duplicate PCO protocolIDs
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13563/3/ggsn_tests/GGSN_Tests.ttcn
File ggsn_tests/GGSN_Tests.ttcn:

https://gerrit.osmocom.org/#/c/13563/3/ggsn_tests/GGSN_Tests.ttcn@773
PS3, Line 773: 		f_PCO_ensure_no_duplicates(ctx.pco_neg);
> What about adding this kind of check inside f_pdp_ctx_act so we don't need to put it in every test? […]
I don't have time to work on this now, and I'd rather improve our test coverage with this test case than keep this out of master for another month :/



-- 
To view, visit https://gerrit.osmocom.org/13563
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d439dab1696196cd125f4d7113b426f1711a405
Gerrit-Change-Number: 13563
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2019 10:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/020524b6/attachment.html>


More information about the gerrit-log mailing list