Change in libosmocore[master]: osmo_sock_get_name_*: Ensure string is returned in error case

Mykola Shchetinin gerrit-no-reply at lists.osmocom.org
Fri May 10 10:04:30 UTC 2019


Mykola Shchetinin has posted comments on this change. ( https://gerrit.osmocom.org/13960 )

Change subject: osmo_sock_get_name_*: Ensure string is returned in error case
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/13960/1/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/13960/1/src/socket.c@815
PS1, Line 815: 		osmo_strlcpy(str, "<error-in-getsockname>", str_len);
Isn't str rewritten in the following line (call to snprintf)?



-- 
To view, visit https://gerrit.osmocom.org/13960
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d56327e96b7a6783cca38b828c5ee74aed776ae
Gerrit-Change-Number: 13960
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Mykola Shchetinin <mykola at pentonet.com>
Gerrit-Comment-Date: Fri, 10 May 2019 10:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190510/18cded44/attachment.html>


More information about the gerrit-log mailing list