Change in osmocom-bb[master]: trxcon/trx_if.c: use read() call instead of recv()

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu May 9 23:53:13 UTC 2019


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/13956 )

Change subject: trxcon/trx_if.c: use read() call instead of recv()
......................................................................

trxcon/trx_if.c: use read() call instead of recv()

According to the man page of recv(), the only difference of this
call from read() is the presence of flags. With a zero flags
argument, recv() is generally equivalent to read().

Change-Id: I6d43bbf8d52c5fbb8ee0592b7d1c1dfd2dd1548e
---
M src/host/trxcon/trx_if.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index 4c10da6..91075f4 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -443,7 +443,7 @@
 	int len, resp, rsp_len;
 	char buf[1500], *p;
 
-	len = recv(ofd->fd, buf, sizeof(buf) - 1, 0);
+	len = read(ofd->fd, buf, sizeof(buf) - 1);
 	if (len <= 0)
 		return len;
 	buf[len] = '\0';
@@ -550,7 +550,7 @@
 	uint32_t fn;
 	int len;
 
-	len = recv(ofd->fd, buf, sizeof(buf), 0);
+	len = read(ofd->fd, buf, sizeof(buf));
 	if (len <= 0)
 		return len;
 

-- 
To view, visit https://gerrit.osmocom.org/13956
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d43bbf8d52c5fbb8ee0592b7d1c1dfd2dd1548e
Gerrit-Change-Number: 13956
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190509/79aaa853/attachment.html>


More information about the gerrit-log mailing list