Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence
gerrit-no-reply at lists.osmocom.org
Thu May 9 17:03:56 UTC 2019
Alexander Chemeris has posted comments on this change. ( https://gerrit.osmocom.org/13723 )
Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence
Patch Set 5:
> > I would appreciate if you remove comparison [...]
> We also discussed this at OsmoDevCon with Harald, and as it turns
> out, modern compilers can perfectly optimize out this comparison
> (i.e. the cmp instruction), since it's a static function and the
> synch. sequences are defined as a static array. We've compiled
> OsmoBTS with clang-8 and checked the results using 'objdump -d -S'.
> However, it doesn't mean that I'm against removing the comparison.
> This is simply not the main problem at the moment. Thanks again for
> your comments and tips, the initial version of this change was much
> worse from performance point of view...
Great. I don't have much experience with modern compilers.
Just curious - have you checked whether gcc is optimizing it as well? And which compiler is used to build Osmocom builds?
To view, visit https://gerrit.osmocom.org/13723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Max <suraev at alumni.ntnu.no>
Gerrit-Comment-Date: Thu, 09 May 2019 17:03:56 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log