Change in osmo-bts[master]: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

Alexander Chemeris gerrit-no-reply at
Thu May 9 17:03:56 UTC 2019

Alexander Chemeris has posted comments on this change. ( )

Change subject: osmo-bts-trx: distinguish 11-bit Access Bursts by synch. sequence

Patch Set 5:

> > I would appreciate if you remove comparison [...]
 > We also discussed this at OsmoDevCon with Harald, and as it turns
 > out, modern compilers can perfectly optimize out this comparison
 > (i.e. the cmp instruction), since it's a static function and the
 > synch. sequences are defined as a static array. We've compiled
 > OsmoBTS with clang-8 and checked the results using 'objdump -d -S'.
 > However, it doesn't mean that I'm against removing the comparison.
 > This is simply not the main problem at the moment. Thanks again for
 > your comments and tips, the initial version of this change was much
 > worse from performance point of view...

Great. I don't have much experience with modern compilers.

Just curious - have you checked whether gcc is optimizing it as well? And which compiler is used to build Osmocom builds?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6d27c6589965c8b59a6d2598a7c43fd860f284
Gerrit-Change-Number: 13723
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy <axilirator at>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-CC: Max <suraev at>
Gerrit-Comment-Date: Thu, 09 May 2019 17:03:56 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list